Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: geolocation crashes electron on macOS #29912

Merged
merged 1 commit into from Jun 29, 2021
Merged

fix: geolocation crashes electron on macOS #29912

merged 1 commit into from Jun 29, 2021

Conversation

@omarkilani
Copy link
Contributor

@omarkilani omarkilani commented Jun 28, 2021

Description of Change

Backport of #29913

Release Notes

Notes: Fixed crashes on macOS when Geolocation was used.

@welcome
Copy link

@welcome welcome bot commented Jun 28, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@omarkilani omarkilani changed the title fix: geolocation crashes electron (#29343) fix: geolocation crashes electron on macOS (#29343) Jun 28, 2021
@trop trop bot mentioned this pull request Jun 28, 2021
2 tasks
@codebytere codebytere changed the title fix: geolocation crashes electron on macOS (#29343) fix: geolocation crashes electron on macOS Jun 28, 2021
@deepak1556 deepak1556 merged commit b465ee7 into electron:13-x-y Jun 29, 2021
10 of 11 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jun 29, 2021

Release Notes Persisted

Fixed crashes on macOS when Geolocation was used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants