Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fsPromises.readFile renderer crash #29928

Merged
merged 1 commit into from Jul 6, 2021
Merged

fix: fsPromises.readFile renderer crash #29928

merged 1 commit into from Jul 6, 2021

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Jun 28, 2021

Description of Change

Closes #29920.

This was occurring because Node.js wasn't properly entering the v8::Context before resolving the Promise. This was fixed in nodejs/node#36413 which is present in v14.17.0 and beyond, and so needs to be backported only to v12 and v13.

Checklist

Release Notes

Notes: Fixed a possible renderer crash when using fsPromises.readFile.

@codebytere codebytere force-pushed the fix-context-crash branch from 335e06c to 4fc70b2 Jun 30, 2021
zcbenz
zcbenz approved these changes Jul 6, 2021
@zcbenz zcbenz merged commit 84eea6f into 13-x-y Jul 6, 2021
13 of 15 checks passed
@zcbenz zcbenz deleted the fix-context-crash branch Jul 6, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jul 6, 2021

Release Notes Persisted

Fixed a possible renderer crash when using fsPromises.readFile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants