Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when clicking links with target=_blank from webview #29951

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Jun 30, 2021

Backport of #29874

See that PR for details.

Notes: fix crash when clicking links with target=_blank from webview

@deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jul 2, 2021

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit 49f5006 into 13-x-y Jul 2, 2021
13 of 15 checks passed
@deepak1556 deepak1556 deleted the trop/13-x-y-bp-fix-crash-when-clicking-links-with-target-_blank-from-webview-1625015436544 branch Jul 2, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jul 2, 2021

Release Notes Persisted

fix crash when clicking links with target=_blank from webview

@NhaLeader
Copy link

@NhaLeader NhaLeader commented Jul 2, 2021

Ok

linonetwo added a commit to tiddly-gittly/TiddlyGit-Desktop that referenced this issue Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants