Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick cc20b36a5845 from chromium #29997

Merged
merged 2 commits into from Jul 4, 2021

Conversation

@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Jul 2, 2021

Use a 100ms timer in MacScrollbarAnimatorImpl::StartScrollbarPaintTimer

MacScrollbarAnimatorImpl::StartScrollbarPaintTimer has a timer that
runs while ShouldSuspendScrollAnimations is true. The timer was changed
from 100ms to 1ms in https://crrev.com/376453. This was later changed to
0ms in https://crrev.com/434428 which caused a performance regression
(https://crbug.com/713669). The timer was then changed back to 1ms in
https://crrev.com/470823 with a comment about giving other tasks time to
cancel the timer. This patch restores the 100ms timer. The comment has
been removed because this timer is more of a polling mechanism.

Bug: 1090000
Change-Id: I4041d9ba5869abbe4ff7d55d56d921c7d90a72ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2903830
Reviewed-by: Hiroki Nakagawa nhiroki@chromium.org
Commit-Queue: Philip Rogers pdr@chromium.org
Cr-Commit-Position: refs/heads/master@{#884506}

Notes: Backported fix for 1090000.

zcbenz
zcbenz approved these changes Jul 4, 2021
@zcbenz zcbenz merged commit 3413e89 into 13-x-y Jul 4, 2021
12 of 15 checks passed
@zcbenz zcbenz deleted the cherry-pick/13-x-y/chromium/cc20b36a5845 branch Jul 4, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jul 4, 2021

Release Notes Persisted

Backported fix for 1090000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants