Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when invoking login callback synchronously #30090

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Jul 12, 2021

Backport of #30068

See that PR for details.

Notes: Fixed a crash when calling the webContents.on('login') callback synchronously.

zcbenz
zcbenz approved these changes Jul 14, 2021
@zcbenz zcbenz merged commit 0bd4f67 into 14-x-y Jul 14, 2021
14 of 15 checks passed
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-crash-when-invoking-login-callback-synchronously-1626118440887 branch Jul 14, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jul 14, 2021

Release Notes Persisted

Fixed a crash when calling the webContents.on('login') callback synchronously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants