Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash creating private key with unsupported algorithm #31137

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Sep 27, 2021

Backport of #31087

See that PR for details.

Notes: Fixed an issue where some calls to crypto.createPrivateKey made with algorithms unsupported by BoringSSL cause a crash when invoking methods on their return values.

@codebytere codebytere force-pushed the trop/15-x-y-bp-fix-crash-creating-private-key-with-unsupported-algorithm-1632747762484 branch from f4fdb79 to 9c294cf Sep 27, 2021
@codebytere codebytere force-pushed the trop/15-x-y-bp-fix-crash-creating-private-key-with-unsupported-algorithm-1632747762484 branch from 9c294cf to 859872e Sep 27, 2021
@jkleinsc jkleinsc merged commit 2cbfd19 into 15-x-y Sep 29, 2021
15 checks passed
Loading
@jkleinsc jkleinsc deleted the trop/15-x-y-bp-fix-crash-creating-private-key-with-unsupported-algorithm-1632747762484 branch Sep 29, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Sep 29, 2021

Release Notes Persisted

Fixed an issue where some calls to crypto.createPrivateKey made with algorithms unsupported by BoringSSL cause a crash when invoking methods on their return values.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants