Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset render_frame_disposed_ after render frame host change #31425

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 14, 2021

Backport of #31401

See that PR for details.

Notes: Fixed a JavaScript exception from webContents if render frame was disposed in WebFrameMain, resets the value of render_frame_disposed_ after updating render frame host

@electron-cation electron-cation bot added the new-pr 🌱 label Oct 14, 2021
@trop trop bot requested a review from VerteDinde Oct 14, 2021
@trop trop bot added 14-x-y backport semver/patch labels Oct 14, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 14, 2021
zcbenz
zcbenz approved these changes Oct 15, 2021
@zcbenz zcbenz merged commit 2eb43ed into 14-x-y Oct 15, 2021
14 of 15 checks passed
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-reset-render_frame_disposed_-after-render-frame-host-change-1634229897937 branch Oct 15, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Oct 15, 2021

Release Notes Persisted

Fixed a JavaScript exception from webContents if render frame was disposed in WebFrameMain, resets the value of render_frame_disposed_ after updating render frame host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants