Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate valid config.gypi #31441

Merged
merged 1 commit into from Oct 18, 2021
Merged

fix: generate valid config.gypi #31441

merged 1 commit into from Oct 18, 2021

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Oct 15, 2021

Backport of #31404.

Notes: Generate valid config.gypi file in Node.js headers.

@zcbenz zcbenz requested a review from as a code owner Oct 15, 2021
@electron-cation electron-cation bot added the new-pr 🌱 label Oct 15, 2021
@trop trop bot mentioned this pull request Oct 15, 2021
@trop trop bot added 16-x-y backport semver/patch labels Oct 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 15, 2021
@ckerr ckerr merged commit fe16016 into 16-x-y Oct 18, 2021
15 checks passed
@ckerr ckerr deleted the valid-config-gypi-16 branch Oct 18, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Oct 18, 2021

Release Notes Persisted

Generate valid config.gypi file in Node.js headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants