Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: black window on screen capture when content protection is enabled #31550

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 22, 2021

Backport of #31340

See that PR for details.

Notes: Fixed black window when screen capturing a content-protected BrowserWindow on Windows 10.

@electron-cation electron-cation bot added the new-pr 🌱 label Oct 22, 2021
@trop trop bot added 13-x-y backport semver/patch labels Oct 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 22, 2021
zcbenz
zcbenz approved these changes Oct 22, 2021
@zcbenz zcbenz merged commit 930dde3 into 13-x-y Oct 22, 2021
13 of 14 checks passed
@zcbenz zcbenz deleted the trop/13-x-y-bp-fix-black-window-on-screen-capture-when-content-protection-is-enabled-1634889157666 branch Oct 22, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Oct 22, 2021

Release Notes Persisted

Fixed black window when screen capturing a content-protected BrowserWindow on Windows 10.

@Slapbox
Copy link
Contributor

@Slapbox Slapbox commented Jan 17, 2022

@zcbenz do you have any thoughts on #32072? I feel extremely confident this PR is the cause.

@zcbenz
Copy link
Member

@zcbenz zcbenz commented Jan 24, 2022

@Slapbox The code path in this change only runs when setContentProtection API is called, so if your app uses the API then this PR would be likely related to the bug.

@Slapbox
Copy link
Contributor

@Slapbox Slapbox commented Jan 25, 2022

@zcbenz, thanks for your reply! Indeed, removing all references to setContentProtection fixes the bug.

The bug occurs even if setContentProtection is used only to set the value to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants