Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setContentProtection affects BrowserWindow frame #31832

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 15, 2021

Backport of #31768

See that PR for details.

Notes: Fixed window frame glitch when calling setContentProtection.

@electron-cation electron-cation bot added the new-pr 🌱 label Nov 15, 2021
@trop trop bot requested a review from deermichel Nov 15, 2021
@trop trop bot added 16-x-y backport semver/patch labels Nov 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 15, 2021
@codebytere
Copy link
Member

@codebytere codebytere commented Nov 15, 2021

Failure

chromium features window.open disables JavaScript when it is disabled on the parent window

not germane.

@codebytere codebytere merged commit e8ba44c into 16-x-y Nov 15, 2021
14 of 15 checks passed
@codebytere codebytere deleted the trop/16-x-y-bp-fix-setcontentprotection-affects-browserwindow-frame-1636969914499 branch Nov 15, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Nov 15, 2021

Release Notes Persisted

Fixed window frame glitch when calling setContentProtection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants