Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 1a8af2da50e4 from chromium #31902

Merged
merged 3 commits into from Nov 22, 2021

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Nov 18, 2021

[M96] Deleting unused field: FetchEventPreloadHandle::url_loader.

The FetchEventPreloadHandle::url_loader field is not really used - it
is only needed to keep the URLLoader alive (and this can be accomplished
in a simpler way, by keeping the mojo::PendingRemote in the Browser
process).

This CL removes the FetchEventPreloadHandle::url_loader field and the
FetchEventPreloadHandle and WebFetchEventPreloadHandle types (collapsing
these handle types into their only other remaining field:
mojo::PendingReceivernetwork::mojom::URLLoaderClient).

(cherry picked from commit dbe67ccde52e30acf6a66b1b9cc83768a067fa6a)

Fixed: 1264477
Change-Id: I9c9c54900d79e92ac08eeb43536c938fa84a58f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252914
Reviewed-by: Daniel Cheng dcheng@chromium.org
Reviewed-by: Ben Kelly wanderview@chromium.org
Reviewed-by: Hiroki Nakagawa nhiroki@chromium.org
Commit-Queue: Łukasz Anforowicz lukasza@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#937895}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3262600
Bot-Commit: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Commit-Queue: Ben Kelly wanderview@chromium.org
Cr-Commit-Position: refs/branch-heads/4664@{#853}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}

Notes: Backported fix for CVE-2021-38010.

@ppontes ppontes requested a review from as a code owner Nov 18, 2021
@ppontes ppontes added 15-x-y backport-check-skip semver/patch labels Nov 18, 2021
@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Nov 18, 2021
@deepak1556 deepak1556 merged commit 1fc7634 into 15-x-y Nov 22, 2021
15 checks passed
@deepak1556 deepak1556 deleted the cherry-pick/15-x-y/chromium/1a8af2da50e4 branch Nov 22, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Nov 22, 2021

Release Notes Persisted

Backported fix for CVE-2021-38010.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport-check-skip security 🔒 semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants