Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BrowserView setBackgroundColor needs two calls #31948

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 22, 2021

Backport of #31863

See that PR for details.

Notes: Fixed a potential issue when setting backgroundColor on BrowserViews.

@electron-cation electron-cation bot added the new-pr 🌱 label Nov 22, 2021
@trop trop bot requested a review from codebytere Nov 22, 2021
@trop trop bot added 17-x-y backport semver/patch labels Nov 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 22, 2021
zcbenz
zcbenz approved these changes Nov 22, 2021
@zcbenz zcbenz merged commit 984c675 into 17-x-y Nov 22, 2021
15 checks passed
@zcbenz zcbenz deleted the trop/17-x-y-bp-fix-browserview-setbackgroundcolor-needs-two-calls-1637541555650 branch Nov 22, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Nov 22, 2021

Release Notes Persisted

Fixed a potential issue when setting backgroundColor on BrowserViews.

vikunja-bot pushed a commit to go-vikunja/desktop that referenced this issue Nov 25, 2021
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [electron](https://github.com/electron/electron) | devDependencies | patch | [`16.0.1` -> `16.0.2`](https://renovatebot.com/diffs/npm/electron/16.0.1/16.0.2) |

---

### Release Notes

<details>
<summary>electron/electron</summary>

### [`v16.0.2`](https://github.com/electron/electron/releases/v16.0.2)

[Compare Source](electron/electron@v16.0.1...v16.0.2)

### Release Notes for v16.0.2

#### Fixes

-   Fixed a potential issue when setting backgroundColor on `BrowserView`s. [#&#8203;31947](electron/electron#31947) <span style="font-size:small;">(Also in [14](electron/electron#31945), [15](electron/electron#31946), [17](https://github.com/electron/electron/pull/31948))</span>
-   Fixed console windows from ELECTRON_RUN_AS_NODE instances. [#&#8203;31973](electron/electron#31973) <span style="font-size:small;">(Also in [17](https://github.com/electron/electron/pull/31972))</span>

#### Other Changes

-   Updated Chromium to 96.0.4664.55. [#&#8203;31909](electron/electron#31909)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/69
Co-authored-by: renovate <renovatebot@kolaente.de>
Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants