Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aspect ratio when max width/height is set #31956

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 22, 2021

Backport of #29101

See that PR for details.

Notes: fixed respecting aspect ratio when maximum size is set on BrowserWindow

Add the native frame border size to the minimum and maximum size if
the view reports its size as the client size. It allows to enlarge
window to proper values when aspect ratio and max width/height are
set. It also fixes DCHECK which was triggered when user tried to
enlarge window above dimensions set during creation of the
BrowserWindow.
@trop trop bot requested a review from as a code owner Nov 22, 2021
@electron-cation electron-cation bot added the new-pr 🌱 label Nov 22, 2021
@trop trop bot added 15-x-y backport semver/patch labels Nov 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 22, 2021
@jkleinsc jkleinsc merged commit 6226507 into 15-x-y Nov 24, 2021
15 checks passed
@jkleinsc jkleinsc deleted the trop/15-x-y-bp-fix-aspect-ratio-when-max-width-height-is-set-1637573500358 branch Nov 24, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Nov 24, 2021

Release Notes Persisted

fixed respecting aspect ratio when maximum size is set on BrowserWindow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants