Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate valid config.gypi #31989

Merged

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 24, 2021

Backport of #31404

See that PR for details.

Notes: Generate valid config.gypi file in Node.js headers.

@trop trop bot requested a review from as a code owner Nov 24, 2021
@electron-cation electron-cation bot added the new-pr 🌱 label Nov 24, 2021
@trop trop bot requested a review from zcbenz Nov 24, 2021
@trop trop bot mentioned this pull request Nov 24, 2021
@trop trop bot added 13-x-y backport semver/patch labels Nov 24, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 24, 2021
@jkleinsc jkleinsc merged commit b07b268 into 13-x-y Nov 30, 2021
15 checks passed
@jkleinsc jkleinsc deleted the trop/13-x-y-bp-fix-generate-valid-config-gypi-1637771869253 branch Nov 30, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Nov 30, 2021

Release Notes Persisted

Generate valid config.gypi file in Node.js headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants