Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gtk_native_dialog_run() calls show() internally #32080

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 2, 2021

Backport of #32049

See that PR for details.

Notes: Assertion failure happening in the showSaveDialogSync() code path has been fixed. (Fixes #31997)

In the synchronous code path, gtk_native_dialog_run() will call
gtk_native_dialog_show(). Previously this was causing an assertion to be
hit at run time.
@electron-cation electron-cation bot added the new-pr 🌱 label Dec 2, 2021
@trop trop bot added 14-x-y backport semver/patch labels Dec 2, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 2, 2021
zcbenz
zcbenz approved these changes Dec 6, 2021
@zcbenz zcbenz merged commit 5e36eed into 14-x-y Dec 6, 2021
12 of 15 checks passed
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-gtk_native_dialog_run-calls-show-internally-1638418803327 branch Dec 6, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Dec 6, 2021

Release Notes Persisted

Assertion failure happening in the showSaveDialogSync() code path has been fixed. (Fixes #31997)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants