Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset render_frame_disposed_ after render frame host change #32130

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 8, 2021

Backport of #31401

See that PR for details.

Notes: Fixed a JavaScript exception from webContents if render frame was disposed in WebFrameMain, resets the value of render_frame_disposed_ after updating render frame host

@electron-cation electron-cation bot added the new-pr 🌱 label Dec 8, 2021
@trop trop bot requested a review from VerteDinde Dec 8, 2021
@trop trop bot added 13-x-y backport semver/patch labels Dec 8, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 8, 2021
zcbenz
zcbenz approved these changes Jan 4, 2022
@zcbenz zcbenz merged commit 8283f19 into 13-x-y Jan 4, 2022
12 of 15 checks passed
@zcbenz zcbenz deleted the trop/13-x-y-bp-fix-reset-render_frame_disposed_-after-render-frame-host-change-1638979302767 branch Jan 4, 2022
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jan 4, 2022

Release Notes Persisted

Fixed a JavaScript exception from webContents if render frame was disposed in WebFrameMain, resets the value of render_frame_disposed_ after updating render frame host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants