Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 891020ed64d4 from angle #32223

Merged
merged 3 commits into from Jan 10, 2022

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Dec 16, 2021

[M96] Ignore the pixel unpack state for compressed textures.

From OpenGL ES 3 spec: All pixel storage modes are ignored when decoding
a compressed texture image
This was causing a bad access when calling compressedTexImage3D
with GL_UNPACK_IMAGE_HEIGHT greater than the image height.

Bug: chromium:1267496
Change-Id: I9b1f4c645548af64f2695fd23262225a1ad07cd7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296622
Commit-Queue: Jonah Ryan-Davis jonahr@google.com
Reviewed-by: Geoff Lang geofflang@chromium.org
Reviewed-by: Shahbaz Youssefi syoussefi@chromium.org
(cherry picked from commit 870f458f507ff7ba0f67b28a30a27955ce79dd3e)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309097
Reviewed-by: Jonah Ryan-Davis jonahr@google.com
Reviewed-by: Jamie Madill jmadill@chromium.org

Notes: Backported fix for CVE-2021-4058.

@ppontes ppontes requested a review from as a code owner Dec 16, 2021
@ppontes ppontes added 15-x-y backport-check-skip semver/patch labels Dec 16, 2021
@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Dec 16, 2021
@ppontes ppontes force-pushed the cherry-pick/15-x-y/angle/891020ed64d4 branch from 292d98b to 1704465 Compare Dec 16, 2021
@ppontes ppontes force-pushed the cherry-pick/15-x-y/angle/891020ed64d4 branch from 0538367 to bc22a66 Compare Dec 20, 2021
zcbenz
zcbenz approved these changes Jan 4, 2022
@zcbenz zcbenz changed the title chore: cherry-pick 891020ed64d4 from angle chore: cherry-pick 891020ed64d4 from angle FIX CI Jan 4, 2022
@zcbenz zcbenz changed the title chore: cherry-pick 891020ed64d4 from angle FIX CI chore: cherry-pick 891020ed64d4 from angle Jan 4, 2022
@jkleinsc jkleinsc merged commit ec7408a into 15-x-y Jan 10, 2022
14 of 15 checks passed
@jkleinsc jkleinsc deleted the cherry-pick/15-x-y/angle/891020ed64d4 branch Jan 10, 2022
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jan 10, 2022

Release Notes Persisted

Backported fix for CVE-2021-4058.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport-check-skip security 🔒 semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants