Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register wrong command for setAsDefaultProtocolClient #32328

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 4, 2022

Backport of #32220

See that PR for details.

Notes: Bug fixed for registering protocol in windows which used to set invalid command if the execution path included space.

@electron-cation electron-cation bot added the new-pr 🌱 label Jan 4, 2022
@trop trop bot added 14-x-y backport semver/patch labels Jan 4, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 label Jan 4, 2022
zcbenz
zcbenz approved these changes Jan 4, 2022
@zcbenz zcbenz merged commit 7a1c596 into 14-x-y Jan 4, 2022
12 of 15 checks passed
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-register-wrong-command-for-setasdefaultprotocolclient-1641260910958 branch Jan 4, 2022
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jan 4, 2022

Release Notes Persisted

Bug fixed for registering protocol in windows which used to set invalid command if the execution path included space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants