Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: left is a valid mode in contents.openDevTools() options #32372

Merged
merged 1 commit into from Jan 10, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 6, 2022

Description of Change

Add missing left mode to contents.openDevTools() options.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added

Release Notes

Notes: none

@miniak miniak added semver/patch target/13-x-y target/14-x-y target/15-x-y target/16-x-y target/17-x-y labels Jan 6, 2022
@miniak miniak self-assigned this Jan 6, 2022
@electron-cation electron-cation bot added the new-pr 🌱 label Jan 6, 2022
ppontes
ppontes approved these changes Jan 6, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 label Jan 7, 2022
@codebytere
Copy link
Member

@codebytere codebytere commented Jan 10, 2022

Failure not relevant.

@codebytere codebytere merged commit 6d8a858 into main Jan 10, 2022
18 of 19 checks passed
@codebytere codebytere deleted the miniak/devtools-mode-left branch Jan 10, 2022
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jan 10, 2022

No Release Notes

@trop
Copy link
Contributor

@trop trop bot commented Jan 10, 2022

I was unable to backport this PR to "13-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/13-x-y and removed target/13-x-y labels Jan 10, 2022
@trop
Copy link
Contributor

@trop trop bot commented Jan 10, 2022

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/14-x-y label Jan 10, 2022
@trop
Copy link
Contributor

@trop trop bot commented Jan 10, 2022

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

@trop trop bot commented Jan 10, 2022

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/15-x-y and removed target/15-x-y target/16-x-y labels Jan 10, 2022
@trop
Copy link
Contributor

@trop trop bot commented Jan 10, 2022

I have automatically backported this PR to "17-x-y", please check out #32392

@trop trop bot removed the target/17-x-y label Jan 10, 2022
@trop
Copy link
Contributor

@trop trop bot commented Jan 10, 2022

@miniak has manually backported this PR to "16-x-y", please check out #32403

@trop
Copy link
Contributor

@trop trop bot commented Jan 10, 2022

@miniak has manually backported this PR to "15-x-y", please check out #32404

@trop
Copy link
Contributor

@trop trop bot commented Jan 10, 2022

@miniak has manually backported this PR to "14-x-y", please check out #32405

@trop trop bot added merged/16-x-y and removed in-flight/16-x-y labels Jan 10, 2022
@trop trop bot added merged/15-x-y and removed in-flight/15-x-y labels Jan 10, 2022
@trop trop bot added merged/14-x-y merged/17-x-y and removed in-flight/14-x-y in-flight/17-x-y labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/14-x-y merged/15-x-y merged/16-x-y merged/17-x-y semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants