Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow x64 arch on Mac Rosetta #32382

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 7, 2022

Backport of #32266

See that PR for details.

Notes: Allowed specifying x64 arch on Mac Rosetta via npm_config_arch.

If the npm_config_arch environment variable is set on Mac, then use the
specified architecture rather than overriding it to x64.
@trop trop bot requested a review from as a code owner Jan 7, 2022
@electron-cation electron-cation bot added the new-pr 🌱 label Jan 7, 2022
@trop trop bot mentioned this pull request Jan 7, 2022
2 tasks
@trop trop bot added 17-x-y backport semver/patch labels Jan 7, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 label Jan 7, 2022
@jkleinsc jkleinsc merged commit cef58e9 into 17-x-y Jan 10, 2022
14 of 15 checks passed
@jkleinsc jkleinsc deleted the trop/17-x-y-bp-fix-allow-x64-arch-on-mac-rosetta-1641545628889 branch Jan 10, 2022
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jan 10, 2022

Release Notes Persisted

Allowed specifying x64 arch on Mac Rosetta via npm_config_arch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants