Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip crashpad_handler binary #32549

Merged

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 20, 2022

Backport of #32540

See that PR for details.

Notes: Strip symbols from crashpad_handler binary on Linux, reducing bundle size.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 20, 2022
@trop trop bot requested a review from nornagon January 20, 2022 03:49
@trop trop bot mentioned this pull request Jan 20, 2022
2 tasks
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 20, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 20, 2022
@zcbenz zcbenz merged commit cc50d1b into 17-x-y Jan 24, 2022
@zcbenz zcbenz deleted the trop/17-x-y-bp-fix-strip-crashpad_handler-binary-1642650578006 branch January 24, 2022 11:06
@release-clerk
Copy link

release-clerk bot commented Jan 24, 2022

Release Notes Persisted

Strip symbols from crashpad_handler binary on Linux, reducing bundle size.

@lights0123
Copy link

This didn't actually do anything: it's named chrome_crashpad_handler, not crashpad_handler, so it's ~70MB unstripped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants