Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent UAF crash in setCertificateVerifyProc #33255

Merged
merged 2 commits into from Apr 6, 2022

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Mar 11, 2022

Backport of #33204

Notes: Fixed a network service crash that could occur when using setCertificateVerifyProc.

@nornagon nornagon requested review from a team as code owners Mar 11, 2022
@nornagon nornagon added the semver/patch label Mar 11, 2022
@electron-cation electron-cation bot added the new-pr 🌱 label Mar 11, 2022
@trop trop bot removed the semver/patch label Mar 11, 2022
@trop trop bot added 16-x-y backport semver/patch labels Mar 11, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 11, 2022
jkleinsc
jkleinsc previously requested changes Mar 16, 2022
Copy link
Contributor

@jkleinsc jkleinsc left a comment

patch fails to apply

@nornagon nornagon requested a review from jkleinsc Apr 4, 2022
@jkleinsc jkleinsc merged commit 0dd20a2 into 16-x-y Apr 6, 2022
15 checks passed
@jkleinsc jkleinsc deleted the backport/16-x-y/fix-setcertverifyproc-cancellation branch Apr 6, 2022
@release-clerk
Copy link

release-clerk bot commented Apr 6, 2022

Release Notes Persisted

Fixed a network service crash that could occur when using setCertificateVerifyProc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants