-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: libuv patches to address child_process.spawn slowness #33406
Merged
jkleinsc
merged 5 commits into
15-x-y
from
trop/15-x-y-bp-fix-libuv-patches-to-address-child_process-spawn-slowness-1648042291728
Mar 29, 2022
Merged
fix: libuv patches to address child_process.spawn slowness #33406
jkleinsc
merged 5 commits into
15-x-y
from
trop/15-x-y-bp-fix-libuv-patches-to-address-child_process-spawn-slowness-1648042291728
Mar 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
trop
bot
added
15-x-y
backport
This is a backport PR
semver/patch
backwards-compatible bug fixes
labels
Mar 23, 2022
jkleinsc
previously requested changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patches fail to apply
nornagon
approved these changes
Mar 29, 2022
jkleinsc
approved these changes
Mar 29, 2022
Merging as lint has passed but it is not marked in GitHub as such. |
jkleinsc
deleted the
trop/15-x-y-bp-fix-libuv-patches-to-address-child_process-spawn-slowness-1648042291728
branch
March 29, 2022 23:45
Release Notes Persisted
|
This was referenced Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #33337
See that PR for details.
Notes: Fixed slowness when using child_process.spawn and related methods on macOS Big Sur and newer.