Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: libuv patches to address child_process.spawn slowness #33406

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 23, 2022

Backport of #33337

See that PR for details.

Notes: Fixed slowness when using child_process.spawn and related methods on macOS Big Sur and newer.

@trop trop bot requested review from as code owners Mar 23, 2022
@electron-cation electron-cation bot added the new-pr 🌱 label Mar 23, 2022
@trop trop bot requested a review from nornagon Mar 23, 2022
@trop trop bot added 15-x-y backport semver/patch labels Mar 23, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 23, 2022
jkleinsc
jkleinsc previously requested changes Mar 28, 2022
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Patches fail to apply

@deepak1556 deepak1556 self-assigned this Mar 29, 2022
@deepak1556 deepak1556 removed their assignment Mar 29, 2022
@deepak1556 deepak1556 requested a review from jkleinsc Mar 29, 2022
@jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Mar 29, 2022

Merging as lint has passed but it is not marked in GitHub as such.

@jkleinsc jkleinsc merged commit e5e8dd5 into 15-x-y Mar 29, 2022
14 of 15 checks passed
@jkleinsc jkleinsc deleted the trop/15-x-y-bp-fix-libuv-patches-to-address-child_process-spawn-slowness-1648042291728 branch Mar 29, 2022
@release-clerk
Copy link

@release-clerk release-clerk bot commented Mar 29, 2022

Release Notes Persisted

Fixed slowness when using child_process.spawn and related methods on macOS Big Sur and newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants