Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BrowserView background color in webContents #33478

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 28, 2022

Backport of #33435

See that PR for details.

Notes: Fixed an issue with background colors being improperly applied to BrowserViews on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 28, 2022
@trop trop bot requested a review from codebytere March 28, 2022 16:47
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 28, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 28, 2022
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test modifications use screen-helper which doesn't exist in 18-x-y.

Copy link
Contributor

@miniak miniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix seems to be regressing #31722

@miniak miniak self-requested a review June 22, 2022 05:45
@miniak miniak force-pushed the trop/18-x-y-bp-fix-browserview-background-color-in-webcontents-1648486050780 branch from 5398b6a to 43706c1 Compare June 30, 2022 14:04
@miniak miniak requested a review from jkleinsc June 30, 2022 14:54
@miniak
Copy link
Contributor

miniak commented Jun 30, 2022

@jkleinsc build issue fixed

@VerteDinde VerteDinde dismissed jkleinsc’s stale review June 30, 2022 18:54

PR is now going green

@VerteDinde VerteDinde merged commit 3823245 into 18-x-y Jun 30, 2022
15 of 16 checks passed
@VerteDinde VerteDinde deleted the trop/18-x-y-bp-fix-browserview-background-color-in-webcontents-1648486050780 branch June 30, 2022 19:35
@release-clerk
Copy link

release-clerk bot commented Jun 30, 2022

Release Notes Persisted

Fixed an issue with background colors being improperly applied to BrowserViews on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants