Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report more detailed errors in shell.openExternal() on Windows #33657

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 7, 2022

Backport of #33620

See that PR for details.

Notes: shell.openExternal() now reports more detailed errors on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 label Apr 7, 2022
@trop trop bot requested a review from miniak Apr 7, 2022
@trop trop bot added 16-x-y backport semver/patch labels Apr 7, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 7, 2022
miniak
miniak approved these changes Apr 8, 2022
@deepak1556 deepak1556 merged commit 9ca00c6 into 16-x-y Apr 11, 2022
15 checks passed
@deepak1556 deepak1556 deleted the trop/16-x-y-bp-fix-report-more-detailed-errors-in-shell-openexternal-on-windows-1649354932402 branch Apr 11, 2022
@release-clerk
Copy link

release-clerk bot commented Apr 11, 2022

Release Notes Persisted

shell.openExternal() now reports more detailed errors on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants