Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 1a31e2110440 from chromium #33856

Merged
merged 3 commits into from Apr 25, 2022

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 20, 2022

[css-typed-om] Disallow CSS-wide keywords for StylePropertyMap.set

We don't support this properly, and the spec does not handle CSS-keywords
either. Disallow it until we can add proper support for this.

(cherry picked from commit 02e4b18febb37de8baea718bc2f62cfb5fe56e23)

Fixed: 1292905
Bug: 1310761
Change-Id: Ieb3d20edfea72c2ccb0928536fdfd86d10aad1a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551609
Reviewed-by: Rune Lillesveen futhark@chromium.org
Commit-Queue: Anders Hartvoll Ruud andruud@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#986411}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3572186
Commit-Queue: Srinivas Sista srinivassista@chromium.org
Auto-Submit: Srinivas Sista srinivassista@chromium.org
Commit-Queue: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/branch-heads/4896@{#1041}
Cr-Branched-From: 1f63ff4bc27570761b35ffbc7f938f6586f7bee8-refs/heads/main@{#972766}

Notes: Backported fix for chromium:1310761.

@ppontes ppontes requested review from a team as code owners Apr 20, 2022
@ppontes ppontes added 15-x-y backport-check-skip semver/patch labels Apr 20, 2022
@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Apr 20, 2022
zcbenz
zcbenz approved these changes Apr 21, 2022
@zcbenz zcbenz merged commit 742aab7 into 15-x-y Apr 25, 2022
14 checks passed
@zcbenz zcbenz deleted the cherry-pick/15-x-y/chromium/1a31e2110440 branch Apr 25, 2022
@release-clerk
Copy link

release-clerk bot commented Apr 25, 2022

Release Notes Persisted

Backported fix for chromium:1310761.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport-check-skip security 🔒 semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants