Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 5cb934a23d from chromium #33860

Merged
merged 1 commit into from Apr 21, 2022

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 20, 2022

M100: Change ownership of BlobBytesProvider.

Rather than immediately passing ownership to a cross-thread
SelfOwnedReceiver while retaining a raw pointer, instead maintain
ownership in a unique_ptr as long as it is needed, only transferring
ownership to a SelfOwnedReceiver when BlobData is done with the
BlobBytesProvider.

Also clean-up/tighten down sequence checks for BlobBytesProvider a bit.

(cherry picked from commit 7222e9825fc02acc962e005c59885ee2f26df185)

Bug: 1285234
Change-Id: I7273e886a0bab2ae489b680d786991c9e4ff1dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553304
Reviewed-by: Austin Sullivan asully@chromium.org
Commit-Queue: Marijn Kruisselbrink mek@chromium.org
Cr-Original-Commit-Position: refs/heads/main@{#986111}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3568972
Auto-Submit: Marijn Kruisselbrink mek@chromium.org
Bot-Commit: Rubber Stamper rubber-stamper@appspot.gserviceaccount.com
Cr-Commit-Position: refs/branch-heads/4896@{#1040}
Cr-Branched-From: 1f63ff4bc27570761b35ffbc7f938f6586f7bee8-refs/heads/main@{#972766}

Notes: Backported fix for CVE-2022-1305.

@ppontes ppontes added security 🔒 semver/patch backport-check-skip 15-x-y labels Apr 20, 2022
@ppontes ppontes requested review from a team as code owners Apr 20, 2022
zcbenz
zcbenz approved these changes Apr 21, 2022
@zcbenz zcbenz merged commit a31e722 into 15-x-y Apr 21, 2022
14 checks passed
@zcbenz zcbenz deleted the cherry-pick/15-x-y/chromium/5cb934a23d branch Apr 21, 2022
@release-clerk
Copy link

release-clerk bot commented Apr 21, 2022

Release Notes Persisted

Backported fix for CVE-2022-1305.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport-check-skip security 🔒 semver/patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants