Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: offscreen rendering crash on input select #34092

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 5, 2022

Backport of #34069

See that PR for details.

Notes: Fixed an OSR crash happening when input select items were rendered.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 5, 2022
@trop trop bot requested a review from codebytere May 5, 2022 13:55
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 5, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 5, 2022
@MarshallOfSound MarshallOfSound merged commit fe96879 into 18-x-y May 5, 2022
@MarshallOfSound MarshallOfSound deleted the trop/18-x-y-bp-fix-offscreen-rendering-crash-on-input-select-1651758889473 branch May 5, 2022 18:49
@release-clerk
Copy link

release-clerk bot commented May 5, 2022

Release Notes Persisted

Fixed an OSR crash happening when input select items were rendered.

vikunja-bot pushed a commit to go-vikunja/desktop that referenced this pull request May 11, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [electron](https://github.com/electron/electron) | devDependencies | patch | [`18.2.0` -> `18.2.2`](https://renovatebot.com/diffs/npm/electron/18.2.0/18.2.2) |

---

### Release Notes

<details>
<summary>electron/electron</summary>

### [`v18.2.2`](https://github.com/electron/electron/releases/v18.2.2)

[Compare Source](electron/electron@v18.2.0...v18.2.2)

### Release Notes for v18.2.2

#### Fixes

-   Fixed a crash on Windows when opening apps in multiple, separate user sessions. [#&#8203;34161](electron/electron#34161) <span style="font-size:small;">(Also in [19](https://github.com/electron/electron/pull/34160))</span>
-   Fixed an OSR crash happening when input select items were rendered. [#&#8203;34092](electron/electron#34092) <span style="font-size:small;">(Also in [17](electron/electron#34091), [19](https://github.com/electron/electron/pull/34093))</span>
-   Fixed an issue where calling `SetLoginItemSettings()` could potentially cause network volumes to be incorrectly mounted. [#&#8203;34106](electron/electron#34106) <span style="font-size:small;">(Also in [17](electron/electron#34107), [19](https://github.com/electron/electron/pull/34108))</span>
-   Fixed crash on startup due to missing gtk symbol on older distros. [#&#8203;34150](electron/electron#34150) <span style="font-size:small;">(Also in [19](https://github.com/electron/electron/pull/34151))</span>

#### Other Changes

-   Backported fix for CVE-2022-1485. [#&#8203;34052](electron/electron#34052)
-   Backported fix for CVE-2022-1497. [#&#8203;34072](electron/electron#34072)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/93
Co-authored-by: renovate <renovatebot@kolaente.de>
Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants