Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 902f0d144a5b from chromium #35097

merged 4 commits into from Jul 29, 2022


Copy link

@ppontes ppontes commented Jul 27, 2022

Mitigate bad cast in OffscreenCanvas::GetFontSelector

This change will cause the browser to crash if the execution context
is not a Window or WorkerGlobalScope. This is a temporary solution
to handle the case where the execution context is an
AudioWorkletGlobalScope. The longer term solution, which will be
implemented in a follow-up CL, is to block OffscreenCanvas objects from
being transferred to AudioWorklets, as required by the postMessage spec.


(cherry picked from commit 028c11e59fd41bc22eff06dbec10fe9b0e82bd04)

Change-Id: Ief5e37eca6dff14098b12cdbe6fc362c3dd87d1d
Auto-Submit: Justin Novosad
Reviewed-by: Juanmi Huertas
Commit-Queue: Juanmi Huertas
Cr-Original-Commit-Position: refs/heads/main@{#1017357}
Commit-Queue: Srinivas Sista
Cr-Commit-Position: refs/branch-heads/5005@{#1254}
Cr-Branched-From: 5b4d9450fee01f821b6400e947b3839727643a71-refs/heads/main@{#992738}

Notes: Security: backported fix for chromium:1334864.

@ppontes ppontes requested review from a team as code owners July 27, 2022 17:48
@ppontes ppontes added 18-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Jul 27, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 27, 2022
@jkleinsc jkleinsc merged commit cfee328 into 18-x-y Jul 29, 2022
15 of 16 checks passed
@jkleinsc jkleinsc deleted the cherry-pick/18-x-y/chromium/902f0d144a5b branch July 29, 2022 14:57
Copy link

release-clerk bot commented Jul 29, 2022

Release Notes Persisted

Security: backported fix for chromium:1334864.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
18-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants