Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 664e0d8b4cfb from chromium #35102

merged 2 commits into from Jul 28, 2022


Copy link

@ppontes ppontes commented Jul 27, 2022

[M96-LTS] Fix incorrect text itemization for \r codepoint

M96 merge issues:
Tests Clusterfuzz_Issue_1298286/1299054 aren't present
in M96 and caused a merge conflict.

The "\r" codepoint should be split to be rendered in a single
harfbuzz run (same as "\n").

We do recognize these sequences as newline:

Previously, the itemization will leave the "\r" with the previous
run. This is leading to incorrect multiline lines splitting.

(cherry picked from commit eee0c5ca752ad50df9986c551cb98226ce078893)

Bug: 1287804
Change-Id: Idfc00a3cf147eb53258d5da9ea105e2d6dc25f05
Commit-Queue: Etienne Bergeron
Cr-Original-Commit-Position: refs/heads/main@{#1014955}
Reviewed-by: Etienne Bergeron
Commit-Queue: Roger Felipe Zanoni da Silva
Cr-Commit-Position: refs/branch-heads/4664@{#1662}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}

Notes: Security: backported fix for 1287804.

@ppontes ppontes requested review from a team as code owners July 27, 2022 18:43
@ppontes ppontes added 18-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Jul 27, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 27, 2022
Copy link

merging as lint failure is known issue fixed via #35105.

@jkleinsc jkleinsc merged commit b5bc30d into 18-x-y Jul 28, 2022
15 of 16 checks passed
@jkleinsc jkleinsc deleted the cherry-pick/18-x-y/chromium/664e0d8b4cfb branch July 28, 2022 15:54
Copy link

release-clerk bot commented Jul 28, 2022

Release Notes Persisted

Security: backported fix for 1287804.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
18-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants