Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply chromium commit 30a32e6 #35370

Merged
merged 1 commit into from Aug 23, 2022

Conversation

rzhao271
Copy link
Contributor

Description of Change

Applies Chromium commit 30a32e6 to align Electron's WCO a bit more with Chromium's.

Upstream Chromium bug (see comment 14): https://bugs.chromium.org/p/chromium/issues/detail?id=1316028.

This PR does not fix the WCO spacer colour issue.

CC @deepak1556

Checklist

Release Notes

Notes: Modified the WCO maximized button style to match Windows 11 more closely.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 23, 2022
zcbenz
zcbenz approved these changes Aug 23, 2022
@zcbenz zcbenz changed the title chore: Apply Chromium commit 30a32e6 chore: apply chromium commit 30a32e6 Aug 23, 2022
@zcbenz zcbenz merged commit 0ff6508 into electron:main Aug 23, 2022
13 of 14 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 23, 2022

Release Notes Persisted

Modified the WCO maximized button style to match Windows 11 more closely.

@rzhao271 rzhao271 deleted the rzhao271/wco-corner-radius branch October 10, 2022 16:53
rzhao271 added a commit to rzhao271/electron that referenced this pull request Oct 10, 2022
@trop
Copy link
Contributor

trop bot commented Oct 10, 2022

@rzhao271 has manually backported this PR to "20-x-y", please check out #35968

rzhao271 added a commit to rzhao271/electron that referenced this pull request Oct 10, 2022
chore: Apply Chromium commit 30a32e6
@trop
Copy link
Contributor

trop bot commented Oct 10, 2022

@rzhao271 has manually backported this PR to "21-x-y", please check out #35970

@trop trop bot added in-flight/21-x-y merged/20-x-y PR was merged to the "20-x-y" branch. and removed in-flight/20-x-y labels Oct 10, 2022
jkleinsc pushed a commit that referenced this pull request Oct 11, 2022
chore: apply chromium commit 30a32e6 (#35370)

chore: Apply Chromium commit 30a32e6
@trop trop bot added merged/21-x-y PR was merged to the "21-x-y" branch. and removed in-flight/21-x-y labels Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/20-x-y PR was merged to the "20-x-y" branch. merged/21-x-y PR was merged to the "21-x-y" branch. no-backport semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants