From 606415d9077105a2e68c4a4777f33f7c8008b042 Mon Sep 17 00:00:00 2001 From: Adrian Petrescu Date: Mon, 22 Aug 2022 22:34:38 -0400 Subject: [PATCH 1/2] Use absolute URL in faq.md image link The relative link is rendered relative to the host domain, which works fine when viewing it on Github, but since you also use the same generated HTML in your doc site, the link is broken. See here: https://www.electronjs.org/docs/latest/faq#the-font-looks-blurry-what-is-this-and-what-can-i-do Using an absolute URL here should fix the issue on the main site. --- docs/faq.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/faq.md b/docs/faq.md index 174104aee9b0c..7e3e7428f122c 100644 --- a/docs/faq.md +++ b/docs/faq.md @@ -161,4 +161,4 @@ Notice that just setting the background in the CSS does not have the desired eff [indexed-db]: https://developer.mozilla.org/en-US/docs/Web/API/IndexedDB_API [message-port]: https://developer.mozilla.org/en-US/docs/Web/API/MessagePort [browser-window]: api/browser-window.md -[subpixel rendering example]: images/subpixel-rendering-screenshot.gif +[subpixel rendering example]: https://github.com/electron/electron/raw/main/docs/images/subpixel-rendering-screenshot.gif From 303ace0b138e2c99a2b28f491cd0f21fd4c90128 Mon Sep 17 00:00:00 2001 From: Adrian Petrescu Date: Mon, 5 Sep 2022 10:04:52 -0400 Subject: [PATCH 2/2] Use inline image reference for subpixel rendering example As suggested by @dsanders11 --- docs/faq.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/faq.md b/docs/faq.md index 7e3e7428f122c..84b3b5cf6e201 100644 --- a/docs/faq.md +++ b/docs/faq.md @@ -135,7 +135,7 @@ is only available in renderer processes. If [sub-pixel anti-aliasing](https://alienryderflex.com/sub_pixel/) is deactivated, then fonts on LCD screens can look blurry. Example: -![subpixel rendering example] +![Subpixel rendering example](images/subpixel-rendering-screenshot.gif) Sub-pixel anti-aliasing needs a non-transparent background of the layer containing the font glyphs. (See [this issue](https://github.com/electron/electron/issues/6344#issuecomment-420371918) for more info). @@ -161,4 +161,3 @@ Notice that just setting the background in the CSS does not have the desired eff [indexed-db]: https://developer.mozilla.org/en-US/docs/Web/API/IndexedDB_API [message-port]: https://developer.mozilla.org/en-US/docs/Web/API/MessagePort [browser-window]: api/browser-window.md -[subpixel rendering example]: https://github.com/electron/electron/raw/main/docs/images/subpixel-rendering-screenshot.gif