Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick c83640db21b5 from chromium #35925

Merged
merged 2 commits into from Oct 6, 2022

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Oct 5, 2022

build: set DTSDKBuild correctly when generating plist files

Currently we set DTSDKBuild to the version of the SDK used to build
Chromium. This value is supposed to be the build version (this is
what xcode sets it to for instance). We read this value out of the
SDK directly and use it instead.

Change-Id: Ieb7990f13095683ad8c026f027b2605ae39523a4

Notes: none

@MarshallOfSound MarshallOfSound requested review from a team as code owners October 5, 2022 18:29
@MarshallOfSound MarshallOfSound added 21-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Oct 5, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Oct 5, 2022
@MarshallOfSound MarshallOfSound merged commit 80a4ea2 into 21-x-y Oct 6, 2022
20 checks passed
@MarshallOfSound MarshallOfSound deleted the cherry-pick/21-x-y/chromium/c83640db21b5 branch October 6, 2022 11:28
@release-clerk
Copy link

release-clerk bot commented Oct 6, 2022

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants