Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose the built-in electron module via the ESM loader #35956

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 10, 2022

Backport of #35930

See that PR for details.

Notes: You can now import the built-in electron module via ESModule loaders, i.e. import('electron') and import 'electron' now work natively

Co-authored-by: Samuel Attard <sattard@salesforce.com>
@trop trop bot requested review from a team as code owners October 10, 2022 10:02
@trop trop bot requested a review from MarshallOfSound October 10, 2022 10:03
@trop trop bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 10, 2022
@MarshallOfSound MarshallOfSound merged commit 619a88c into 20-x-y Oct 11, 2022
20 checks passed
@MarshallOfSound MarshallOfSound deleted the trop/20-x-y-bp-fix-expose-the-built-in-electron-module-via-the-esm-loader-1665396170460 branch October 11, 2022 23:06
@release-clerk
Copy link

release-clerk bot commented Oct 11, 2022

Release Notes Persisted

You can now import the built-in electron module via ESModule loaders, i.e. import('electron') and import 'electron' now work natively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants