New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the support for Mac App Store #5205

Merged
merged 2 commits into from Apr 19, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Apr 19, 2016

By using the SandBox Policy Language, I finally got Electron sandboxed without rewriting Chromium's IPC system. But to achieve this we have added an temporary-exception entry to the entitlements, which may make the app fail to pass the review of Mac App Store.

Also another problem is the renderer process unable to read the files under Electron.app/Contents/Resources, because the renderer process belongs to the Electron Helper.app, which is not the same with Electron.app. I work around it by making Electron.app/Contents/Resources a symbol link to Electron.app/Contents/Frameworks/Electron Framework.framework/Resources, so app now lives under the Electron Framework.framework and the sandbox is happy with that. This might be a breaking change for some apps.

Anyway this PR should be able to fix the support for Mac App Store, /cc @kevinsawicki.

Close #3871.

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Apr 19, 2016

Contributor

Hmm actually I think we don't even need to modify the code, we were just not using the correct entitlements when sandboxing the app.

Contributor

zcbenz commented Apr 19, 2016

Hmm actually I think we don't even need to modify the code, we were just not using the correct entitlements when sandboxing the app.

@zcbenz zcbenz merged commit 34ee298 into master Apr 19, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3091519 succeeded in 81s
Details
electron-linux-ia32 Build #3091520 succeeded in 83s
Details
electron-linux-x64 Build #3091521 succeeded in 112s
Details
electron-mas-x64 Build #897 succeeded in 4 min 51 sec
Details
electron-osx-x64 Build #914 succeeded in 5 min 22 sec
Details
electron-win-ia32 Build #3091522 succeeded in 165s
Details
electron-win-x64 Build #3091523 succeeded in 165s
Details

@zcbenz zcbenz deleted the mas-fix branch Apr 19, 2016

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Apr 19, 2016

Contributor

Awesome work @zcbenz ❤️ 💚 💜 💙

Contributor

kevinsawicki commented Apr 19, 2016

Awesome work @zcbenz ❤️ 💚 💜 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment