New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemPreferences module #5282

Merged
merged 8 commits into from Apr 25, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Apr 25, 2016

systemPreferences

Also deprecate the system preferences related APIs in app module.

Close #1861
Close #4954.

@danhp

This comment has been minimized.

Member

danhp commented Apr 25, 2016

Shouldn't the documentation for the platform-theme-changed event also be removed from the app doc?

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Apr 25, 2016

@phamdaniel Good catch, thanks!

@zcbenz zcbenz merged commit 63d0704 into master Apr 25, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3119027 succeeded in 80s
Details
electron-linux-ia32 Build #3119028 succeeded in 81s
Details
electron-linux-x64 Build #3119029 succeeded in 107s
Details
electron-mas-x64 Build #949 succeeded in 5 min 0 sec
Details
electron-osx-x64 Build #963 succeeded in 5 min 22 sec
Details
electron-win-ia32 Build #3119030 succeeded in 170s
Details
electron-win-x64 Build #3119031 succeeded in 171s
Details

@zcbenz zcbenz deleted the system-preferences branch Apr 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment