New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix converting from windows virtual keycode back to mac keycode #5298

Merged
merged 1 commit into from Apr 27, 2016

Conversation

Projects
None yet
2 participants
@danhp
Member

danhp commented Apr 26, 2016

Accelerators keys no longer use the virtual keys for symbols with are reached via 'Shift'
For example, Plus now correctly uses + instead of the virtual key Shift+=

Don't have Windows, so I didn't look into that part of the issue.
Ref #1507

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Apr 27, 2016

Looks good to me, thanks!

@zcbenz zcbenz merged commit 7b8a05f into electron:master Apr 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danhp danhp deleted the danhp:fix-mac-accelerators branch Apr 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment