New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API: IsDefaultProtocolClient #5302

Merged
merged 1 commit into from Apr 28, 2016

Conversation

Projects
None yet
3 participants
@ritazh
Contributor

ritazh commented Apr 26, 2016

@zcbenz @felixrieseberg This should fix #5164

std::wstring exe = L"\"" + exePath + L"\" \"%1\"";
if (keyVal == exe) {
// Default value is the same as current file path
return true;

This comment has been minimized.

@felixrieseberg

felixrieseberg Apr 26, 2016

Member

Bonus spaces 😸

@felixrieseberg felixrieseberg changed the title from :zap: Add API: IsDefaultProtocolClient to Add API: IsDefaultProtocolClient Apr 26, 2016

@felixrieseberg

This comment has been minimized.

Member

felixrieseberg commented Apr 26, 2016

:party: Sweet! I found two little extra spaces, but otherwise, this looks 👍

if (!bundle){
return false;
}
NSString* bundleId = base::mac::CFToNSCast(bundle);

This comment has been minimized.

@zcbenz

zcbenz Apr 27, 2016

Contributor

The bundle is a CFStringRef so it has to be released, you can reference how Chromium did it:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/shell_integration_mac.mm&sq=package:chromium&type=cs&l=34

This comment has been minimized.

@ritazh

ritazh Apr 27, 2016

Contributor

Thanks for the pointer @zcbenz. 👏 Code updated.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Apr 28, 2016

Thanks!

@zcbenz zcbenz merged commit d9db231 into electron:master Apr 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment