New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: fix some edge cases with download manager #5315

Merged
merged 2 commits into from Apr 28, 2016

Conversation

Projects
None yet
2 participants
@deepak1556
Member

deepak1556 commented Apr 27, 2016

  • Dont attach download dialog to destroyed webcontents window
  • Use DownloadItem::IsSavePackageDownload to prevent will-download event for savePage method instead of relying on mimetype.

Fixes #5228
Fixes #5278

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Apr 28, 2016

👍

@zcbenz zcbenz merged commit 122652a into electron:master Apr 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment