New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the userData directory is created before ready event #5340

Merged
merged 1 commit into from Apr 29, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Apr 29, 2016

Because of #5237, the userData dir is not created unless the first window is loaded, usually it is fine but we should at least guarantee it is created in the ready event.

Close #5336.

@zcbenz zcbenz merged commit cb45c94 into master Apr 29, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3146572 succeeded in 38s
Details
electron-linux-ia32 Build #3146573 succeeded in 34s
Details
electron-linux-x64 Build #3146574 succeeded in 58s
Details
electron-mas-x64 Build #993 succeeded in 5 min 47 sec
Details
electron-osx-x64 Build #1002 succeeded in 6 min 4 sec
Details
electron-win-ia32 Build #3146575 succeeded in 51s
Details
electron-win-x64 Build #3146576 succeeded in 53s
Details

@zcbenz zcbenz deleted the create-user-data branch Apr 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment