New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated apis #5373

Merged
merged 31 commits into from May 9, 2016

Conversation

Projects
None yet
4 participants
@kevinsawicki
Contributor

kevinsawicki commented May 2, 2016

Retargets #5335 to the 1-0-release branch.

@@ -96,17 +95,6 @@ BrowserWindow.prototype._init = function () {
// Notify the creation of the window.
app.emit('browser-window-created', {}, this)
// Be compatible with old APIs.

This comment has been minimized.

@kevinsawicki

kevinsawicki May 2, 2016

Contributor

@zcbenz These are okay to remove for 1.0 right?

This comment has been minimized.

@zcbenz

zcbenz May 2, 2016

Contributor

I'm good removing them, people might be complaining though since we didn't generate deprecation notices for them.

This comment has been minimized.

@kevinsawicki

kevinsawicki May 2, 2016

Contributor

Yeah, I think it is still valuable cleanup to do before 1.0 or else we'd leave them in until 2.0.

@danhp

This comment has been minimized.

Member

danhp commented May 6, 2016

Was digging through some code yesterday and I found this little guy: https://github.com/electron/electron/blob/remove-deprecated-apis/atom/browser/api/atom_api_window.cc#L81-L88

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented May 6, 2016

@danhp thanks so much for pointing those out, removed in ef459c7

@zcbenz zcbenz merged commit e139012 into 1-0-release May 9, 2016

7 checks passed

electron-linux-arm Build #3186791 succeeded in 38s
Details
electron-linux-ia32 Build #3186792 succeeded in 34s
Details
electron-linux-x64 Build #3186793 succeeded in 60s
Details
electron-mas-x64 Build #1083 succeeded in 6 min 0 sec
Details
electron-osx-x64 Build #1088 succeeded in 6 min 50 sec
Details
electron-win-ia32 Build #96 succeeded in 5 min 10 sec
Details
electron-win-x64 Build #87 succeeded in 5 min 7 sec
Details

@zcbenz zcbenz deleted the remove-deprecated-apis branch May 9, 2016

rhysd added a commit to rhysd/electron-window-state that referenced this pull request May 11, 2016

Fix removed 'app' module in Electron v1.0.0
Electron v1.0.0 was out and deprecated modules are removed.
I fixed requiring deprecated module.

electron/electron#5373

rhysd added a commit to rhysd/electron-window-state that referenced this pull request May 11, 2016

Fix removed 'app' module in Electron v1.0.0
Electron v1.0.0 was out and deprecated modules are removed.
I fixed requiring deprecated module.

electron/electron#5373

@thomasjo thomasjo referenced this pull request Aug 3, 2016

Merged

Upgrade Electron #12300

29 of 29 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment