New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the 'context-menu' event. #5379

Merged
merged 3 commits into from May 5, 2016

Conversation

Projects
None yet
3 participants
@danhp
Member

danhp commented May 3, 2016

This PR exposes Chrome's context menu event on browser side.
This is my first time writing a hefty chunk of C++ so this could use a bit of scrutiny.

Ref: Chrome ContextMenuParams

Closes #3210

field, the type of that field. Possible values are `none`, `plain-text`,
`password`, `other`.
* `menuSourceType` String - Input source that invoked the context menu.
Can be `none`, `mouse`, `keyboard`, `touch`, `touch-menu`.

This comment has been minimized.

@zcbenz

zcbenz May 4, 2016

Contributor

I prefer to use touchMenu and plainText instead of touch-menu and plain-text, the former follows the style of other APIs, like the dialog.showOpenDialog and webContents.sendInputEvent.

This comment has been minimized.

@danhp

danhp May 4, 2016

Member

Sounds good, I wasn't too sure on the style to use there.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented May 5, 2016

Awesome! 👍

@zcbenz zcbenz merged commit 0901a70 into electron:master May 5, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danhp danhp deleted the danhp:context-menu branch May 5, 2016

@dfournier

This comment has been minimized.

dfournier commented May 11, 2016

Looks fabulous! Any ETA to see it in a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment