New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollBounce option and disable it by default #5412

Merged
merged 1 commit into from May 6, 2016

Conversation

Projects
None yet
4 participants
@zcbenz
Contributor

zcbenz commented May 6, 2016

This PR disables the scroll bounce (rubber banding) effect on OS X by default, and add a scrollBounce option to enable it.

We used to disable scroll bounce effect completely by patching Webkit, but in recent versions of Chrome the way scroll bounce is implemented had changed and the scroll bounce effect was back.

Close #5397.

@zcbenz zcbenz merged commit 7b83d92 into master May 6, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3181052 succeeded in 43s
Details
electron-linux-ia32 Build #3181053 succeeded in 36s
Details
electron-linux-x64 Build #3181054 succeeded in 62s
Details
electron-mas-x64 Build #1070 succeeded in 6 min 2 sec
Details
electron-osx-x64 Build #1076 succeeded in 6 min 9 sec
Details
electron-win-ia32 Build #84 succeeded in 5 min 15 sec
Details
electron-win-x64 Build #73 succeeded in 5 min 21 sec
Details

@zcbenz zcbenz deleted the osx-disable-rubber-banding branch May 6, 2016

@revintec

This comment has been minimized.

revintec commented Sep 3, 2016

Hi, I'm using Electron 1.3.5 on OS X 10.10.5, using this on Main thread:
var mainWindow=new BrowserWindow({width:800,height:600,webPreferences:{scrollBounce:true}});
However it won't enable scrollBounce though Render process has "--scroll-bounce" in its commandline, and Electron's code seems checking it correctly in atom_renderer_client.cc
Is this a BUG? Can anyone reproduce it? @zcbenz

@Riokai

This comment has been minimized.

Riokai commented Sep 12, 2016

webPreferences: {
    scrollBounce: true
}

not work for me

@Dexwell

This comment has been minimized.

Dexwell commented Mar 27, 2017

Same problem here. I created a bug report issue #9033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment