New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RemoveAsDefaultProtocolClient on OS X #5440

Merged
merged 2 commits into from May 8, 2016

Conversation

Projects
None yet
3 participants
@bengotow
Contributor

bengotow commented May 7, 2016

Follow up from #5385 - it looks like there's no way to truly reset the default protocol handler on Mac OS X. This patch basically just chooses the first available handler which is not the user's app and sets it to the default. In my (pretty limited) testing with mailto, it seems like the first handler returned is Apple's, so I think this will do the trick...

@felixrieseberg

This comment has been minimized.

Member

felixrieseberg commented May 7, 2016

This is a lot better than doing nothing 👍

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented May 8, 2016

Looks good to me, can you also update the docs of app.removeAsDefaultProtocolClient?

@bengotow

This comment has been minimized.

Contributor

bengotow commented May 8, 2016

Definitely - just updated to mention that it works on OS X.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented May 8, 2016

👍

@zcbenz zcbenz merged commit 6b79f53 into master May 8, 2016

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-mas-x64 Build #1092 succeeded in 5 min 50 sec
Details
electron-osx-x64 Build #1097 succeeded in 6 min 8 sec
Details
electron-win-ia32 Build #106 succeeded in 5 min 21 sec
Details
electron-win-x64 Build #96 succeeded in 5 min 46 sec
Details

@zcbenz zcbenz deleted the bengotow/remove-default-protocol branch May 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment