New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the IDWeakMap to accept arbitrary key type #5491

Merged
merged 11 commits into from May 11, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented May 11, 2016

When storing renderer process callbacks in the main process, there are two keys for one remote object: 1) the webContents ID and 2) the object ID.

This PR extends the IDWeakMap to accept arbitrary key type so it is possible to use two IDs as key, instead of relying on hacks to merge two IDs into one ID.

Close #5476.

@zcbenz zcbenz merged commit 959f7a1 into master May 11, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3207747 succeeded in 38s
Details
electron-linux-ia32 Build #3207748 succeeded in 34s
Details
electron-linux-x64 Build #3207749 succeeded in 108s
Details
electron-mas-x64 Build #1133 succeeded in 5 min 58 sec
Details
electron-osx-x64 Build #1137 succeeded in 6 min 22 sec
Details
electron-win-ia32 Build #150 succeeded in 5 min 29 sec
Details
electron-win-x64 Build #142 succeeded in 5 min 26 sec
Details

@zcbenz zcbenz deleted the key-weak-map branch May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment