New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link with VS2015 libraries statically for Release build #5602

Merged
merged 4 commits into from May 19, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented May 19, 2016

In the Windows 10 SDK Microsoft introduced the dependency of Universal CRT, which is not available in Windows <= 8.1 by default and users have to get it via Windows Update, so for some machines there will be errors like "api-ms-win-crt-runtime-l1-1-0.dll not found".

This PR changes to link with VC++ libraries statically can get rid of the dependency for Universal CRT.

Close #5528.

Refs:
https://bugs.chromium.org/p/chromium/issues/detail?id=495944
https://blogs.msdn.microsoft.com/vcblog/2015/03/03/introducing-the-universal-crt/
electron/libchromiumcontent#210

@zcbenz zcbenz merged commit 53d0db0 into master May 19, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3264268 succeeded in 56s
Details
electron-linux-ia32 Build #3264269 succeeded in 48s
Details
electron-linux-x64 Build #3264270 succeeded in 110s
Details
electron-mas-x64 Build #1226 succeeded in 4 min 53 sec
Details
electron-osx-x64 Build #1229 succeeded in 5 min 43 sec
Details
electron-win-ia32 Build #236 succeeded in 6 min 7 sec
Details
electron-win-x64 Build #230 succeeded in 5 min 54 sec
Details

@zcbenz zcbenz deleted the static-linking-vs-runtime branch May 19, 2016

@miniak

This comment has been minimized.

Contributor

miniak commented May 21, 2016

The UCRT can be deployed locally

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented May 22, 2016

@miniak There are more than 20 DLLs in UCRT, it is a bit cray to ship all of them in Electron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment