New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osx horizontal sheet offset #5603

Merged
merged 4 commits into from May 21, 2016

Conversation

Projects
None yet
2 participants
@leethomas
Contributor

leethomas commented May 19, 2016

Closes #5447. Though I was trying to maintain backwards compatibility, I'm not sure if this is the best way to do it. I don't want to bloat the API but this works for now.

win.setSheetOffsets(100, -100);

screen shot 2016-05-19 at 12 09 37 am

The old win.setSheetOffset(100) still works as expected, setting only the Y offset.

screen shot 2016-05-19 at 12 23 08 am

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented May 20, 2016

How about extending win.setSheetOffset to accept both 1 and 2 parameters? So we don't have to add a new API.

The implementation of Window::SetAspectRatio can be used as example.

@leethomas

This comment has been minimized.

Contributor

leethomas commented May 20, 2016

Done. Thanks! 👍

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented May 21, 2016

👍

@zcbenz zcbenz merged commit 6f3d0e1 into electron:master May 21, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment