New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rejection of remote promises #5666

Merged
merged 2 commits into from May 24, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented May 23, 2016

I think 6de9c43 introduced a regression where the onRejected handler was ignored in the RPC handler for promises since only the first argument, v, was used. Previously it passed a bound version of then which would have caused all arguments to be passed through.

This pull request adds an explicit second argument that will be passed to the proxied Promise.then calls.

Closes #5111

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented May 24, 2016

Awesome 👍

@zcbenz zcbenz merged commit cd444e8 into master May 24, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3288067 succeeded in 39s
Details
electron-linux-ia32 Build #3288068 succeeded in 34s
Details
electron-linux-x64 Build #3288069 succeeded in 110s
Details
electron-mas-x64 Build #1279 succeeded in 5 min 36 sec
Details
electron-osx-x64 Build #1281 succeeded in 6 min 4 sec
Details
electron-win-ia32 Build #286 succeeded in 5 min 57 sec
Details
electron-win-x64 Build #281 succeeded in 5 min 58 sec
Details

@zcbenz zcbenz deleted the remote-promise-reject branch May 24, 2016

@BornaP BornaP referenced this pull request May 24, 2016

Closed

Upgrade to electron 1.0 #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment