Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ATOM_SHELL_INTERNAL_RUN_AS_NODE support #5682

Merged
merged 3 commits into from May 25, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Copy link
Contributor

kevinsawicki commented May 24, 2016

Should have been removed in #5373 but wasn't.

I think this is fine to remove now since the 1.0 env var docs went out with only mentioning ELECTRON_RUN_AS_NODE

Depends on electron/node#15

@zcbenz zcbenz merged commit 4cd0de0 into master May 25, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #3298352 succeeded in 43s
Details
electron-linux-ia32 Build #3298353 succeeded in 37s
Details
electron-linux-x64 Build #3298354 succeeded in 113s
Details
electron-mas-x64 Build #1303 succeeded in 5 min 47 sec
Details
electron-osx-x64 Build #1305 succeeded in 5 min 44 sec
Details
electron-win-ia32 Build #310 succeeded in 6 min 11 sec
Details
electron-win-x64 Build #306 succeeded in 6 min 13 sec
Details

@zcbenz zcbenz deleted the remove-old-run-as-node-env-var branch May 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.