New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly notify observers when window prevents close #5701

merged 1 commit into from May 26, 2016


None yet
2 participants

danhp commented May 25, 2016

It used to somewhat work on OS X since we were just letting the system block the close. But the action was never passed back to relevant observers.
I don't know how to write the tests for this behaviour so I stopped here...

Closes #5680


This comment has been minimized.


zcbenz commented May 26, 2016


@zcbenz zcbenz merged commit 20b09e9 into electron:master May 26, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
continuous-integration/travis-ci/pr The Travis CI build passed

@danhp danhp deleted the danhp:propagate-close branch May 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment